Skip to content

[PWGHF] Fix position of continue in Xic+ tree creator in case of fill gen acc info - #18401

Merged
fgrosa merged 6 commits into
AliceO2Group:masterfrom
fgrosa:xic
Oct 23, 2026
Merged

fgrosa merged 6 commits into
AliceO2Group:masterfrom
fgrosa:xic

Conversation

@fgrosa

@fgrosa fgrosa commented Oct 22, 2026

Copy link
Copy Markdown
Collaborator

No description provided.

@github-actions github-actions Bot added the pwghf PWG-HF label Oct 22, 2026
@github-actions github-actions Bot changed the title Fix position of continue in Xic+ tree creator in case of fill gen acc info [PWGHF] Fix position of continue in Xic+ tree creator in case of fill gen acc info Oct 22, 2026
@github-actions

Copy link
Copy Markdown

O2 linter results: ❌ 0 errors, ⚠️ 4 warnings, 🔕 0 disabled

@alibuild

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/code-check for 420530e at 2026-10-22 09:35:

## sw/BUILD/O2Physics-code-check-latest/log
--
========== List of issues found ==========
++ echo 'To reproduce the results below locally, run: '\''aliBuild build O2Physics-code-check -e ALIBUILD_BASE_HASH=upstream/master'\''.'
To reproduce the results below locally, run: 'aliBuild build O2Physics-code-check -e ALIBUILD_BASE_HASH=upstream/master'.
++ echo 'To apply all automatic fixes, add the '\''-e O2PHYSICS_CHECKER_FIX=1'\'' option.'
To apply all automatic fixes, add the '-e O2PHYSICS_CHECKER_FIX=1' option.
++ echo 'See the documentation for more details at: <https://aliceo2group.github.io/analysis-framework/docs/tools/#running-with-o2physics-code-check>.'
See the documentation for more details at: <https://aliceo2group.github.io/analysis-framework/docs/tools/#running-with-o2physics-code-check>.
++ echo 'Found 5 errors and 1 warnings.'
Found 5 errors and 1 warnings.
++ [[ 5 -gt 0 ]]
++ cat /sw/BUILD/ac3fa73c19330b88b9ef4f996703d64ff4d81f02/O2Physics-code-check/errors.txt
PWGHF/TableProducer/treeCreatorXicToXiPiPi.cxx:750:10: error: no header providing "std::vector" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGHF/TableProducer/treeCreatorXicToXiPiPi.cxx:751:73: error: no header providing "kXiMinus" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGHF/TableProducer/treeCreatorXicToXiPiPi.cxx:751:84: error: no header providing "kPiPlus" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGHF/TableProducer/treeCreatorXicToXiPiPi.cxx:766:76: error: no header providing "kLambda0" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGHF/TableProducer/treeCreatorXicToXiPiPi.cxx:774:86: error: no header providing "kProton" is directly included [misc-include-cleaner,-warnings-as-errors]
++ [[ 1 -gt 0 ]]
++ cat /sw/BUILD/ac3fa73c19330b88b9ef4f996703d64ff4d81f02/O2Physics-code-check/warnings.txt
PWGHF/TableProducer/treeCreatorXicToXiPiPi.cxx:420:327: warning: redundant boolean literal supplied to boolean operator [readability-simplify-boolean-expr]
++ [[ 5 -gt 0 ]]
++ exit 1
--

Full log here.

@alibuild

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/code-check for d8057ee at 2026-10-22 09:43:

## sw/BUILD/O2Physics-code-check-latest/log
--
========== List of issues found ==========
++ echo 'To reproduce the results below locally, run: '\''aliBuild build O2Physics-code-check -e ALIBUILD_BASE_HASH=upstream/master'\''.'
To reproduce the results below locally, run: 'aliBuild build O2Physics-code-check -e ALIBUILD_BASE_HASH=upstream/master'.
++ echo 'To apply all automatic fixes, add the '\''-e O2PHYSICS_CHECKER_FIX=1'\'' option.'
To apply all automatic fixes, add the '-e O2PHYSICS_CHECKER_FIX=1' option.
++ echo 'See the documentation for more details at: <https://aliceo2group.github.io/analysis-framework/docs/tools/#running-with-o2physics-code-check>.'
See the documentation for more details at: <https://aliceo2group.github.io/analysis-framework/docs/tools/#running-with-o2physics-code-check>.
++ echo 'Found 4 errors and 1 warnings.'
Found 4 errors and 1 warnings.
++ [[ 4 -gt 0 ]]
++ cat /sw/BUILD/1c016b0ceb15983a3e7601ca4c1469b8f3ee7b0d/O2Physics-code-check/errors.txt
PWGHF/TableProducer/treeCreatorXicToXiPiPi.cxx:752:73: error: no header providing "kXiMinus" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGHF/TableProducer/treeCreatorXicToXiPiPi.cxx:752:84: error: no header providing "kPiPlus" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGHF/TableProducer/treeCreatorXicToXiPiPi.cxx:767:76: error: no header providing "kLambda0" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGHF/TableProducer/treeCreatorXicToXiPiPi.cxx:775:86: error: no header providing "kProton" is directly included [misc-include-cleaner,-warnings-as-errors]
++ [[ 1 -gt 0 ]]
++ cat /sw/BUILD/1c016b0ceb15983a3e7601ca4c1469b8f3ee7b0d/O2Physics-code-check/warnings.txt
PWGHF/TableProducer/treeCreatorXicToXiPiPi.cxx:421:327: warning: redundant boolean literal supplied to boolean operator [readability-simplify-boolean-expr]
++ [[ 4 -gt 0 ]]
++ exit 1
--

Full log here.

@vkucera

vkucera commented Oct 22, 2026

Copy link
Copy Markdown
Collaborator

Please fix the missing include.

Please consider the following formatting changes to AliceO2Group#18401
@fgrosa
fgrosa enabled auto-merge (squash) October 23, 2026 12:46

@alibuild alibuild left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-approving on behalf of @fgrosa.

@fgrosa
fgrosa merged commit df37dd2 into AliceO2Group:master Oct 23, 2026
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pwghf PWG-HF

Development

Successfully merging this pull request may close these issues.

3 participants